----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/163/#review226 -----------------------------------------------------------
Ship it! Looks fine. Please commit (or let me know if I need to commit it) - Matt On 2008-02-20 08:17:59, Adam Russell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://mattr.info/r/163/ > ----------------------------------------------------------- > > (Updated 2008-02-20 08:17:59) > > > Review request for Kopete. > > > Summary > ------- > > Fixes two Oscar synchronization issues: > 1. Moving a contact from one group to another on the server now moves the > contact on the client. > 2. Once a contact is removed from the server, an option is now given to > delete the metacontact from the client. > > Also added a TODO for group synchronization. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp > trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarlistnonservercontacts.cpp > > Diff: http://mattr.info/r/163/diff > > > Testing > ------- > > 1. Manipulated SSI via another client so that the group for a contact does > not match Kopete's group. Signed on and confirmed group synchronization. > 2. Removed a contact via another client. Signed on, received modified > dialog, and confirmed metacontact removal after selecting the deletion option. > > > Thanks, > > Adam > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
