----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/284/#review289 -----------------------------------------------------------
Looks good, but you should also resize the photo if it's smaller than 32 pixels as it was in the old code. - Roman On 2008-03-09 18:35:46, Carlo Segato wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://mattr.info/r/284/ > ----------------------------------------------------------- > > (Updated 2008-03-09 18:35:46) > > > Review request for Kopete. > > > Summary > ------- > > Avatar scaling and cropping was buggy > http://bugs.kde.org/show_bug.cgi?id=158957 also cropping the image isn't a > good thing to do imho, so with this patch the image is scaled correctly and > if it's not square or less then 96x96 it's resized to 96x96 and centered with > a transparent background > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp > > Diff: http://mattr.info/r/284/diff > > > Testing > ------- > > > Thanks, > > Carlo > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
