On Sat, 15 Mar 2008 08:12:35 +0100, Olivier Goffart <[EMAIL PROTECTED]> wrote:
> Le samedi 15 mars 2008, Roman Jarosz a écrit : >> So here's the patch for non-intrusive notifications. >> >> I've added 3 classes. >> >> InfoEventManager and InfoEvent into libkopete and InfoEventWidget into >> kopete folder. >> >> * InfoEvent is base class for all events. I've tried to make the methods >> and logic in InfoEvent the same as in KNotification. > > Maybe you could have tried to use KNotification dirrectly. (just an idea) I think that it would be difficult. For instance protocols would have to use signals instead of using virtual function void activate( unsigned int action ); in its own event class. If you look at ICQAuthRequestEvent class you see that there is all neccessary code in it and we don't have to use some wrapper class. > >> * InfoEventManager practically only holds the events and emits changed() >> signal. * InfoEventWidget is the widget you see in the screenshot. >> >> The InfoEvent name was just first that came to my mind as I thought about >> this more maybe ServiceEvent or ServiceNontification would be better. What >> you think? >> >> I've also changed the ICQ authorization request to InfoEvent. > > > The event for contact authorisation should be in likopete. > The API can be based on the existing Kopete::UI::ContactAddedNotifyDialog Will look at it _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
