----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://mattr.info:8080/r/336/#review334 -----------------------------------------------------------
I understand that the blue and the red makes it stand out more, but we need to use the standard KDE color scheme stuff for this, since we need to make sure that we honor the user's color scheme rather than hard code a color. I think Kopete::AppearanceSettings takes these things in to account, if not, then perhaps KColorScheme would be a better choice. - Matt On 2008-04-24 01:55:29, Aaron Reichman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://mattr.info:8080/r/336/ > ----------------------------------------------------------- > > (Updated 2008-04-24 01:55:29) > > > Review request for Kopete. > > > Summary > ------- > > A patch to make it easier to distinguish who is who in the kopete history > viewer. It displays full screen names of participants and makes the names > different colors > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/history/historydialog.cpp > > Diff: http://mattr.info:8080/r/336/diff > > > Testing > ------- > > I tested this against kopete .5 from svn. It worked fine, used display names > when they were available otherwise used screen names. I tested it with AIM > and yahoo, can't seem to get jabber (gtalk) working yet. > > > Thanks, > > Aaron > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
