Le lundi 9 juin 2008, Dennis Nienhüser a écrit : > Hi Olivier, > > Olivier Goffart wrote: > > Hi, this patch is better then the current behaviour, and should be > > commited, because the wrong icons are a bug. > > > > But the scaling is wrong. You force 22x22 and 11x11 > > That shouldn't be a problem as the systray icon size is fixed to 22x22.
Yep. unless later we come with an applet that can have bigger icon. But for now 22x22 will work, true. > > The correct fix is to use QIcon instead of QPixmap, and have a > > QIconEngine. I think that Kopete::OnlineStatus should be used here, as it > > already have all the internals to create QIcons for corrects status. > > Maybe it will be easy to add support for the global status in here. > > Good point, I tried that approach but it looked rather ugly: > kopeteonlinestatus* uses overlay icons custom to protocols and these > overlay icons look bad on top of the kopete icon. > Therefore I changed it to a similar approach used by the identity status > widget in kopetewindow.cpp, see the patch attached. Visually that means > the same result except that the overlay icons are a bit smaller and an > overlay icon is used for offline (instead of graying out the kopete > icon). Ok to commit? (strange it doesn't gray for offline... is the status from the Offline category?) How does the icon looks like now? I think I finally prefer the old patch :-) (I think the kopete logo should be used) But commit whichever you prefer if no one else has opinions about it. -- Olivier
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
