On Thu, 04 Sep 2008 00:37:53 +0200, Will Stephenson <[EMAIL PROTECTED]> wrote:
> So it's feature time at SUSE again and I'm developing my patches upstream
> first. The feature is to "add comprehensive lockdown support to Kopete"
> and
> this includes
> * file transfer
> * adding contacts
> * allowed protocols
> * history
> * blocking contacts
> * chat window behaviour
> * emoticons
> * away message behaviour
>
> The attached patches make it possible to
> 1) kiosk which protocols can be loaded
> 2) kiosk which protocols can be seen in the Add Account wizard
> 3) kiosk customContextMenu() actions in the major protocols (by adding
> the
> context menu actions to a temporary KActionCollection, since
> KActionCollection::addAction() applies kiosk policy to the KAction
> objects.
> 4) Fix kdelibs so that [KDE Control Module Restrictions] lockdown works
> again
>
> The Kopete-Kiosk-HOWTO rudimentarily explains which keys and desktop
> files to
> kiosk for which feature. You'll notice I tried to use action names that
> are
> standard as much as possible across protocols - I don't see a need to be
> able
> to lock a feature in one protocol but not another.
>
> Ok to commit?
>
> Will
>
> PS I have just noticed I missed MSN, I will do the same to it as the
> other
> protocols if the rest of the patches are ok.
Please add "temporary action collection, used to apply Kiosk policy to the
actions"
comment into the AIM and ICQ because it's not clear why we want to
add actions into the tempCollection.
In libkopete/kopeteaccount.cpp there is wrong indentation or brackets are wrong.
+ kDebug() << "contactlist has " << d->contacts.count() << " entries";
+ foreach (Contact * t, d->contacts )
{
+ kDebug() << "contactlist contains " << t->contactId();
+ } if ( c && c->metaContact() )
+
+ {
Otherwise looks fine.
Roman
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
