On Oct 2, 2008, at 12:35 PM, David Faure wrote: > I was wondering about the difference between "Use message stack" and > "Use message queue" and kedge hinted on IRC that there might be no > difference anymore, and that it was "used for the Kopete 0.12 > bubble", whatever > that was ;) > > And indeed if I read the grep output below correctly, it only > changes the order of the events > in the event list in the systray icon, i.e. whether clicking on the > systray icon > should call apply on the older or most recent message.... Seems like > a small leftover. > > ./libkopete/private/kopeteviewmanager.cpp:171: d->useQueueOrStack = > Kopete::BehaviorSettings::self()->useMessageQueue() || > Kopete::BehaviorSettings::self()->useMessageStack(); > ./libkopete/kopetebehaviorsettings.kcfg:19: <entry > key="useMessageStack" type="Bool"> > ./kopete/systemtray.cpp:201: if( Kopete::BehaviorSettings::self()- > >useMessageStack() ) > > (excluding the code in the config/ dir itself) > > Permission to clean that up? I assume the "use message stack" option > would be the one to remove, i.e. > the last if should be considered always false and the systray would > call apply on the oldest event.
Sounds fine to me. -- Matt _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
