On Mon, 22 Dec 2008 13:55:48 +0100, David Faure <[email protected]> wrote:
> On Sunday 21 December 2008, Roman Jarosz wrote: >> On Sun, 21 Dec 2008 13:53:24 +0100, Andrea Cimino >> <[email protected]> wrote: >> >> > I tried to make a patch for this: >> > >> > >> http://techbase.kde.org/Projects/Kopete/JuniorJobs#Page_Up_.22Just_Works.22 >> > >> > I like the patched behvaour: if you didn't entered some text in the >> > KRichTextEdit, you scroll the chat history, >> > otherwise you get the same behaviour as before. >> >> Looks good, just one thought maybe it would be better to use >> toPlainText().isEmpty() >> because IMHO you can be atBlockStart even if you have entered some text. > > toPlainText().isEmpty() is slooooow though. > > Why not just document()->isEmpty on the QTextEdit, if there is indeed a > QTextEdit involved? > Yeah you are right, committed. Roman _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
