Attempt number two with brackets fixed up and copyrights added in.
On Sun, Feb 1, 2009 at 12:27 PM, Matt Rogers <[email protected]> wrote: > On Sunday 01 February 2009 02:10:57 Benson Tsai wrote: >> Hello all! >> >> I've been working on reworking the rich text edit component which is >> rather broken in svn at the moment. One major change is the leveraging >> krichtextwidget instead of simply ktextedit to do most of the work >> (ie: all the buttons for formatting). So some of the things that are >> fixed are as follows: >> >> Reasonable behavior of high lighting and font format changes (bold, family, >> etc) Reasonable behavior of background and foreground colors >> Proper support of "base" formatting support (MSN, i'm looking at you) >> >> However, certain features such as background though supported by the >> editor and claimed to be supported by protocol plugins are not >> actually being set at the moment, at least in some protocols. Ditto >> for some things such as alignment. >> >> Here are some statistics: >> >> kopete/kopete/chatwindow/CMakeLists.txt | 10 +- >> kopete/kopete/chatwindow/chattexteditpart.cpp | 276 +++++++-- >> kopete/kopete/chatwindow/chattexteditpart.h | 84 +++- >> kopete/kopete/chatwindow/chatview.cpp | 35 +- >> kopete/kopete/chatwindow/kopetechatwindow.cpp | 36 -- >> kopete/kopete/chatwindow/kopetechatwindow.h | 4 - >> kopete/kopete/chatwindow/kopetechatwindow.rc | 24 +- >> .../chatwindow/kopeterichtexteditpartfull.rc | 31 +- >> kopete/kopete/chatwindow/kopeterichtextwidget.cpp | 425 +++++++++++++ >> kopete/kopete/chatwindow/kopeterichtextwidget.h | 93 +++ >> kopete/kopete/chatwindow/krichtexteditpart.cpp | 626 >> -------------------- kopete/kopete/chatwindow/krichtexteditpart.h | >> 185 ------ >> 12 files changed, 872 insertions(+), 957 deletions(-) >> >> And attached is the patch. >> >> --Benson Tsai > > You need to remove the printing of the message debug output. > > You left your name out of the copyrights and the about data. We'll need these > should we ever need to relicense the code and we need the permission of all > the contributors to do that. > > You need to fix the coding style. Brackets { and } are on separate lines in > the > majority of Kopete's code. > > Right: > > if (someFoo) > { > doSomething(); > } > > Wrong: > > if (someFoo) { > doSomething(); > } > > Thanks > -- > Matt > > _______________________________________________ > kopete-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kopete-devel > >
richtext.patch.gz
Description: GNU Zip compressed data
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
