----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/52/#review80 -----------------------------------------------------------
Ship it! Looks fine to me. Added to my patch queue. I'll commit this later tonight. - Matt On 2009-02-12 09:56:06, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/52/ > ----------------------------------------------------------- > > (Updated 2009-02-12 09:56:06) > > > Review request for Kopete. > > > Summary > ------- > > With the recent rich text widget patch, yahoo's rich text support was > broken by a bit. The text sent is always white (well actually the > color of the background). This is because the regular expression used > to match colors match both font colors (css "color") and background > color (css "background-color"). The patch attached removes background > color before processing font color thus fixing the problem. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahoocontact.cpp 924703 > > Diff: http://reviewboard.kde.org/r/52/diff > > > Testing > ------- > > Tested on Yahoo with a friend, confirmed text is no longer white > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
