> On None, Benson Tsai wrote: > >
Added before screen shot. Review board is being buggy about selecting areas of the image so from the top left to the bottom right are: Classic, Right Aligned, Detailed, Classic with photo, Right Aligned with photo, Detailed with photo Note: there are many more combinations of after I haven't taken a screen shot of (there are basically some 30 combinations if i did my math right) and I haven't taken a screen shot of before with tree lines. - Benson ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/36/#review36 ----------------------------------------------------------- On 2009-02-15 09:21:32, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/36/ > ----------------------------------------------------------- > > (Updated 2009-02-15 09:21:32) > > > Review request for Kopete. > > > Summary > ------- > > I've made a couple modifications to contact list that I thought I > might as well share. The attached patch modifies the contact list (and > related options) to provide the following features: > > 1) Enable/Disable Rounded rectangle for contacts (rounded things are awesome) > 2) Enable/Disable Borders (I personally hate borders around my contact photos) > 3) Instead of having classic, right hand, and detailed with a size > modifier based on whether or not "use photo" is checked, there is now > simply 3 sizes that users can choose from (small - 1 line, medium - 2 > lines, large - 3 lines). You can now enable photo and detail without > changing the size of each contact so you can get a 1 line detailed > view with photos if you want or if you fancy, large photos without > much else other than contact list. I also have right aligned icons as > an option to check regardless of which size it is. > > Here are some stats on my patch: > > .../appearance/appearanceconfig_contactlist.ui | 161 +++++++++++++++++-- > kopete/kopete/contactlist/kopetemetacontactlvi.cpp | 165 > +++++++++++++++----- > kopete/kopete/contactlist/kopetemetacontactlvi.h | 3 +- > kopete/libkopete/kopeteappearancesettings.kcfg | 32 +++- > 4 files changed, 302 insertions(+), 59 deletions(-) > > I've attached two after screenshots. One shows 6 possible permutations of the > contact list and the other shows the updated configuration for the contact > list to accommodate the new functions. > > Will post before screenshots later. > > > Diffs > ----- > > > /trunk/KDE/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_contactlist.ui > 922431 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetemetacontactlvi.h > 922431 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetemetacontactlvi.cpp > 922431 > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg 922431 > > Diff: http://reviewboard.kde.org/r/36/diff > > > Testing > ------- > > I've tested most permutations of possible options > > > Screenshots > ----------- > > after > http://reviewboard.kde.org/r/36/s/2/ > configuration after > http://reviewboard.kde.org/r/36/s/3/ > Configuration before > http://reviewboard.kde.org/r/36/s/12/ > before > http://reviewboard.kde.org/r/36/s/14/ > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
