> On 2009-02-19 06:36:51, Matt Rogers wrote: > > please commit. > > Benson Tsai wrote: > committed > > Frank Roscher wrote: > Thank you for committing it, Benson! > Now, I don't want to be a pain... but this patch might be a candidate for > backporting, too.
backported. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/121/#review164 ----------------------------------------------------------- On 2009-02-18 10:26:01, Frank Roscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/121/ > ----------------------------------------------------------- > > (Updated 2009-02-18 10:26:01) > > > Review request for Kopete. > > > Summary > ------- > > If the pixmap of a non-square contact photo (for example the photos that are > provided by the address book) gets modified using setPixmap (as is the case > when the contact changes status or sends a message) the containing > ImageComponent gets resized to too small a value. This results in a broken > layout, as can be seen with the topmost contact in the attached screenshot. > > The reason is that setPixmap implicitly resizes the ImageComponent to the > size of the pixmap if it's not explicitly told not to do it - but of course > here we still need the sizes dictated by the contactListSize setting. The > patch modifies all setPixmap calls on contact photos (that I could identify) > to not resize the ImageComponents. > > This should be the proper way to fix it as the ImageComponents are used for > other images, too, and really don't need to change size in the case of > contact photos. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetemetacontactlvi.cpp > 927584 > > Diff: http://reviewboard.kde.org/r/121/diff > > > Testing > ------- > > I tested it for about 24 hours on my local setup. Tried to break it with just > about all contact list appearance settings. Still, with stuff like this one > can always miss some special case... > > > Screenshots > ----------- > > broken layout > http://reviewboard.kde.org/r/121/s/20/ > > > Thanks, > > Frank > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
