----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/132/#review209 -----------------------------------------------------------
Ship it! Looks fine. I take it these warnings are due to deprecation in libiris? - Matt On 2009-02-19 22:37:05, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/132/ > ----------------------------------------------------------- > > (Updated 2009-02-19 22:37:05) > > > Review request for Kopete. > > > Summary > ------- > > fixes up some of the warnings that the jabber protocols throws out > > A lot of: > user -> node > host -> domain > userHost -> bare > setResource -> withResource > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemimetypehandler.h 928660 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemimetypehandler.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.h 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbookmarks.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberchatsession.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontactpool.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbergroupchatmanager.cpp > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbergroupcontact.h 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbergroupcontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbergroupmembercontact.h > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberprotocol.h 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberprotocol.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberresource.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberresourcepool.h 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberresourcepool.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbertransport.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/kioslave/jabberdisco.h 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/kioslave/jabberdisco.cpp > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/tasks/jt_ahcommand.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/tasks/mood.cpp 928660 > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabberchangepassword.cpp > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabberchatjoin.cpp > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabberchatroomslist.cpp > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbervcard.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgsearch.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgxmppconsole.cpp 928660 > > Diff: http://reviewboard.kde.org/r/132/diff > > > Testing > ------- > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
