----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/192/ -----------------------------------------------------------
Review request for Kopete. Summary ------- I noticed that the rich text editor did not quite behave as expected when using foreground/background color. As it turns out, I'm not using a hook for on char format update which I should be. I also found out that the functions I wrote intended to override the set background/foreground functions simply never gets called because unfortunately they're not virtual functions and they're only called from a private class which references the class as "KRichTextWidget". Cases: Deleting text (backspace) -> new text format should follow the last character deleted Sending text -> new text format should follow the last character in the last message When deleting a selection, it currently follows the character format where the cursor is--which I feel is reasonable. Diffs ----- /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 931781 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 931781 Diff: http://reviewboard.kde.org/r/192/diff Testing ------- Tested background setting and bolding over AIM and they behave as expected. Thanks, Benson _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
