----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/242/ -----------------------------------------------------------
Review request for Kopete. Summary ------- This patch adds an option to kopete to allow grouping of notifications per contact. If the option is enabled and a contact who already has a notification open messages the user, then that notification will be updated to display "+ N more messages" under the previous message formatting, where N is the number of messages from the user since the notification. I want to add another option after this review is complete to add a configuration option to enable transient notifications with a user-configurable time-out. It was suggested to me that this would be a better fix to the problem, but during discussion myself and others felt that they preferred non-transient notifications. Diffs ----- /trunk/KDE/kdenetwork/kopete/kopete/config/behavior/behaviorconfig_events.ui 935585 /trunk/KDE/kdenetwork/kopete/libkopete/CMakeLists.txt 935585 /trunk/KDE/kdenetwork/kopete/libkopete/kopetebehaviorsettings.kcfg 935585 /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteviewmanager.cpp 935589 Diff: http://reviewboard.kde.org/r/242/diff Testing ------- Been using this for a whole day now, no crashes or unexpected results. There was an error with the notification display even before I wrote the patch, where sometimes the top border of a visual notification is too large, and it doesn't seem to have fixed this problem or made this worse. Screenshots ----------- screenshot of 10 messages from a single contact with this option enabled. http://reviewboard.kde.org/r/242/s/51/ Thanks, James _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
