I'm going skiing today for a week, so I'll commit it when I'm back. Regards, Roman
On Fri, 06 Mar 2009 04:24:29 +0100, Matt Rogers <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/226/#review381 > ----------------------------------------------------------- > > Ship it! > > > Looks fine. You could s/Wrappers/ModelItems since that seems to be what > they really are. Please commit. : > > - Matt > > > On 2009-03-02 14:28:00, Roman Jarosz wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/226/ >> ----------------------------------------------------------- >> >> (Updated 2009-03-02 14:28:00) >> >> >> Review request for Kopete and Roman Jarosz. >> >> >> Summary >> ------- >> >> This patch adds wrappers around Kopete::MetaContact >> (MetaContactWrapper) and Kopete::Group (GroupWrapper). The reason for >> this is to be able to tell in which group MetaContact is because >> MetaContact can be in more groups and when we want to create parent >> QModelIndex we only have pointer to metaContact so the >> MetaContactWrapper object is created every time MetaContact is added to >> some group. >> >> I'm posting it here because it's not the nicest solution but I don't >> see any better right now. >> So do you agree with this change? >> >> PS. group wrapper isn't needed but IMHO it's cleaner this way because >> otherwise we would have to do some casting magic. >> >> >> Diffs >> ----- >> >> /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistmodel.h >> 933212 >> /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistmodel.cpp >> 933293 >> /branches/work/kopete/dev-4.2/kopete/contactlist/kopetecontactlistview.h >> 933323 >> /branches/work/kopete/dev-4.2/kopete/contactlist/kopetecontactlistview.cpp >> >> 933323 >> /branches/work/kopete/dev-4.2/libkopete/kopetecontactlist.h 932952 >> /branches/work/kopete/dev-4.2/libkopete/kopetecontactlist.cpp 932952 >> >> Diff: http://reviewboard.kde.org/r/226/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Roman >> >> > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
