> On 2009-03-09 14:55:57, Detlev Casanova wrote: > > Why not also use libv4l to do image conversion stuff ? Some formats are > > still not supported by Kopete (see bug > > https://bugs.kde.org/show_bug.cgi?id=186080 , this webcam only supports > > S561 and GBRG which aren't suported by kopete) > > Jaroslav Reznik wrote: > Sorry I was misleading you - the purpose of this patch is to support > image conversion, not v4l1 devices. Libv4l2 transparently converts from any > (known) pixel format to V4l2_PIX_FMT_BGR24 or V4l2_PIX_FMT_YUV420 where > necessary. So with libv4l2 enabled there's no need to do conversions in > Kopete code any more. Maybe libv4l should be required to build Kopete but I'm > not sure about its support around distributions.
Ok, that I suppose that it means that when we will try to set a pixel_format, only V4l2_PIX_FMT_BGR24 and V4l2_PIX_FMT_YUV420 would succeed. As long as we only support V4l2_PIX_FMT_BGR24, it would be the one we will use and all the convertion code, the format trying code and the pixel_format enum could be removed, right ? - Detlev ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/266/#review429 ----------------------------------------------------------- On 2009-03-10 01:33:23, Jaroslav Reznik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/266/ > ----------------------------------------------------------- > > (Updated 2009-03-10 01:33:23) > > > Review request for Kopete. > > > Summary > ------- > > This patch adds v4l support to Kopete's video device. Libv4l is wrapper > around v4linux so v4l2 apps can use transparent image conversion. See > attached bug. > > > This addresses bug 177338. > https://bugs.kde.org/show_bug.cgi?id=177338 > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/CMakeLists.txt 937303 > trunk/KDE/kdenetwork/kopete/cmake/modules/FindLibV4L2.cmake PRE-CREATION > trunk/KDE/kdenetwork/kopete/config-kopete.h.cmake 937303 > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/CMakeLists.txt 937303 > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h 937303 > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp 937303 > > Diff: http://reviewboard.kde.org/r/266/diff > > > Testing > ------- > > > Thanks, > > Jaroslav > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
