----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/263/#review435 -----------------------------------------------------------
i can't say that there's anything here in your changes that would cause sending to fail, so perhaps it's best to just apply it to trunk and see what sort of feedback we get trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/logintask.cpp <http://reviewboard.kde.org/r/263/#comment261> why are you setting param 2 to 1 and then adding a param 1 with the screen name? trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/logintask.cpp <http://reviewboard.kde.org/r/263/#comment262> this magic number (2097087) could use some documenting. trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/logintask.cpp <http://reviewboard.kde.org/r/263/#comment263> why change it to 480? is -60 not working? trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/logintask.cpp <http://reviewboard.kde.org/r/263/#comment260> please fix the whitespace here. i also can't tell if this is supposed to be commented out or not. if it's not supposed to be commented out, it would make sense to move it above the commented code. trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp <http://reviewboard.kde.org/r/263/#comment264> please remove the extra whitespace. trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp <http://reviewboard.kde.org/r/263/#comment265> whitespace again. trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp <http://reviewboard.kde.org/r/263/#comment266> remove whitespace at the end of the line. trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp <http://reviewboard.kde.org/r/263/#comment267> the previous use of arg here is cleaner rather than using string concatenation all over the place. Please consider using arg again. - Matt On 2009-03-10 06:11:58, jgroszko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/263/ > ----------------------------------------------------------- > > (Updated 2009-03-10 06:11:58) > > > Review request for Kopete. > > > Summary > ------- > > I'm trying to get Yahoo File Transfers working again, but I've gotten to a > point where I need input from someone with a fresh set of eyes or more brains > than me. > > Receiving files works, but sending files does not. About 10k into the > transfer I see an unknown error code 16, and wireshark shows a bunch of TCP > Duplicate ACKs. The error looks like this in the debug log: > > kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData: read: > 1024 written: 1024 > kopete(6494)/kopete (yahoo) YahooAccount::slotFileTransferBytesProcessed: > Transfer: 2 Bytes: 10240 > kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData: > > kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::connectFailed: 16 : > "an unknown/unexpected error has happened" > > Some input/insight would be awesome, since I'd like to get this working > again... > > > This addresses bug 159584. > https://bugs.kde.org/show_bug.cgi?id=159584 > > > Diffs > ----- > > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/filetransfernotifiertask.cpp > 936143 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/logintask.cpp 936143 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.h 936143 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp > 936143 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/yahootypes.h 936143 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/ymsgprotocol.cpp > 936143 > > Diff: http://reviewboard.kde.org/r/263/diff > > > Testing > ------- > > Received files sent from a Windows Yahoo client, unable to send files to a > Windows Yahoo Client > > > Thanks, > > jgroszko > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
