-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/272/#review461
-----------------------------------------------------------

Ship it!


Looks good. Go ahead and commit. Mail me (tejas AT gja DOT in) if you need me 
to commit this.

- gja


On 2009-03-11 12:16:54, Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/272/
> -----------------------------------------------------------
> 
> (Updated 2009-03-11 12:16:54)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> The status field in the published service description for the Bonjour 
> protocol does not get updated if the presence status changes, it is always 
> kept as "avail". The patch changes that.
> 
> (It seems the Bonjour plugin currently only supports three states, online, 
> away, and offline. But the specs for the protocol I found at 
> http://xmpp.org/registrar/linklocal.html also list "dnd" as an option. If 
> someone could point me to how this state could be added to the Bonjour plugin 
> I would be happy to do it as a next step, after this patch is applied.)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdenetwork/kopete/protocols/bonjour/bonjouraccount.cpp 937885 
> 
> Diff: http://reviewboard.kde.org/r/272/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H.
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to