-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/386/#review561
-----------------------------------------------------------


why not just extend setActive instead of creating a new function? Nothing wrong 
with the current way, just curiousity on my part. :)

Can you provide screenshots of the new dialog and the notification?

- Matt


On 2009-03-22 04:24:39, gja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/386/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 04:24:39)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> This provides the 'ask' option in auto away.
> 
> Ie, when the user returns to a terminal, it asks 'Do you want to become 
> available again'.
> 
> If the user ignore the message for some time, it vanishes.
> 
> 
> This addresses bug 73605.
>     https://bugs.kde.org/show_bug.cgi?id=73605
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdenetwork/kopete/kopete/config/behavior/behaviorconfig_away.ui 
> 942341 
>   trunk/KDE/kdenetwork/kopete/libkopete/kopetebehaviorsettings.kcfg 942341 
>   trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.h 942341 
>   trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.cpp 942341 
> 
> Diff: http://reviewboard.kde.org/r/386/diff
> 
> 
> Testing
> -------
> 
> It works for the following cases:
> 1) User Ignores the message - message disappears
> 2) User clicks 'no' - no change
> 3) User clics 'yes' - becomes available
> 
> 
> Thanks,
> 
> gja
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to