> On 2009-03-24 20:29:45, Matt Rogers wrote: > > looks fine to me. did you do any testing? you left the 'Testing done' > > section blank. > > > > Do you have a SVN account that you can use to commit this, or do I need to > > commit it?
Yeah forgot to add that but it does work as expected with a negative hue value for my camera. Also no i don't have an SVN account, so if you could push this that would be great - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/378/#review606 ----------------------------------------------------------- On 2009-03-25 10:23:00, Brian Johnson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/378/ > ----------------------------------------------------------- > > (Updated 2009-03-25 10:23:00) > > > Review request for Kopete. > > > Summary > ------- > > If one of the v4l2 controls has a minimum value other then 0 kopete will not > correctly calculate value to set the control to. For instance in my webcam > driver the hue is done using a range of > -180 to +180, however when changing the hue using kopete it will only > calculate values between 0 and 360. This patch should fix the issue. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp 942363 > > Diff: http://reviewboard.kde.org/r/378/diff > > > Testing > ------- > > Tested on my webcam with hue set to less then 0. works as expected. > > > Thanks, > > Brian > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
