----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/497/#review774 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp <http://reviewboard.kde.org/r/497/#comment459> I don't like this, it most likely doesn't break anything (because we don't use it in ICQ for ICQ contacts) but in ICQ we don't get status title/message in the same time so if you call setStatusMessage you will delete the status title. So please revert this. The rest looks good - Roman On 2009-04-01 08:24:11, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/497/ > ----------------------------------------------------------- > > (Updated 2009-04-01 08:24:11) > > > Review request for Kopete. > > > Summary > ------- > > 1. make it so that the [icon] name (account) all stays on one line > 2. display the away message (if any) > 3. fix oscar so it sets the individual contact's away message using > setStatusMessage, not just the via the property (why are there two methods > for away messages anyway?). > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp 947888 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp 947888 > > Diff: http://reviewboard.kde.org/r/497/diff > > > Testing > ------- > > > Screenshots > ----------- > > before > http://reviewboard.kde.org/r/497/s/89/ > after > http://reviewboard.kde.org/r/497/s/90/ > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
