> On 2009-09-12 02:21:26, Matt Rogers wrote: > > Commit! > > Raphael Kubo da Costa wrote: > Done. Should this be backported? > > Matt Rogers wrote: > if skypebuttons is present in the 4.3 branch, then yes. >
Done. - Raphael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1574/#review2316 ----------------------------------------------------------- On 2009-09-12 01:42:55, Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1574/ > ----------------------------------------------------------- > > (Updated 2009-09-12 01:42:55) > > > Review request for Kopete. > > > Summary > ------- > > Currently, using Firefox 3.5 with the skypebuttons plugin crashes the browser > on FreeBSD with the following error: > > terminate called after throwing an instance of > '__gnu_cxx::__concurrence_lock_error' > what(): __gnu_cxx::__concurrence_lock_error > > Abort trap (core dumped) > > Until the cause of the problem is properly figured out, not building the > directory by passing -DBUILD_skypebuttons=OFF is a solution. > > Furthermore, looking at the plugin's CMakeLists.txt it always assumes Firefox > (or something similar) is installed, which isn't always the case. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/skype/CMakeLists.txt 1022549 > > Diff: http://reviewboard.kde.org/r/1574/diff > > > Testing > ------- > > By not building and installing the plugin, Firefox stops crashing on every > startup. > > > Thanks, > > Raphael > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
