----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2110/#review3135 -----------------------------------------------------------
i agree with the feature but i dislike the current implementation only because history is currently not in the Kopete core (nothing wrong with the code itself). I would love to see this done as a property (in the same way protocols do properties) that the History plugin sets on the contacts and the metacontacts rather than the current way it's done. This may even simplify the implementation in the model. - Matt On 2009-11-10 00:26:17, Jeremy Van den Eynde wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2110/ > ----------------------------------------------------------- > > (Updated 2009-11-10 00:26:17) > > > Review request for Kopete. > > > Summary > ------- > > This patch adds a new sort option for contacts. It calculates at startup the > total size of the logs of each metacontact, and uses this size for sorting > (most talked to metacontacts are on top). Each contact's log size is updated > when necessary. > > > Diffs > ----- > > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp > 1046123 > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg > 1046123 > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontact.h 1046123 > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontact.cpp 1046123 > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.h 1046123 > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1046123 > /branches/KDE/4.3/kdenetwork/kopete/plugins/history/historylogger.h 1046123 > /branches/KDE/4.3/kdenetwork/kopete/plugins/history/historylogger.cpp > 1046123 > > /branches/KDE/4.3/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_contactlist.ui > 1046123 > > Diff: http://reviewboard.kde.org/r/2110/diff > > > Testing > ------- > > > Thanks, > > Jeremy > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
