-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2334/
-----------------------------------------------------------
(Updated 2009-12-06 23:41:35.522528)
Review request for Kopete.
Changes
-------
trivial
Summary (updated)
-------
Changes done (1. and 2. partially fix bug 213228):
1. Added new formats to `timeFormats`.
2. Fixed importing logs from gadu and wlm (pidgin has gadu-gadu and msn
directories but "GaduProtocol" doesn't contain "gadu-gadu" and "WlmProtocol"
doesn't contain "msn").
3. Changed parsing HTML in parsePidginXml a bit because pidgin actually uses
<br/> for both new line inside the message and for the end of the message. Also
made the code ignoring system messages (however call them) like warnings. I
think that the code is self-explanatory, except two things:
- newly added if clause has to be performed first, otherwise we start parsing
next message, without ending the current;
- we're removing 2 chars from the end of `messageText` - I was too lazy to
find out why, but deleting (-1, 1) or (-2, 1) didn't work as expected; deleting
(-2, 2) just works.
This addresses bug 213228.
https://bugs.kde.org/show_bug.cgi?id=213228
Diffs
-----
/trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.cpp 1059541
Diff: http://reviewboard.kde.org/r/2334/diff
Testing
-------
New timeFormats fixed dates for me.
Thanks to gadu fix I was able to import my gadu logs (didn't work before).
Importing messages with new lines inside them now works. Previously they were
truncated at the first new line.
Thanks,
Bartosz
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
