> On 2010-01-10 10:48:48, Pali Rohár wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp,
> >  line 215
> > <http://reviewboard.kde.org/r/2534/diff/2/?file=16746#file16746line215>
> >
> >     Skype support setting status message when you go offline. (You can see 
> > status message from other people if they are offline) So I think you can 
> > add code for offline status too.

indeed you are write. There are two scenarios.
1. to rely on the fact that the user sets an offline message.
2. to make skype to go offline with the last message set by the user.

I opted for the former. Probably the best way would be to check if an offline 
status is set and if true use it, if not use the last user defined.


> On 2010-01-10 10:48:48, Pali Rohár wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp,
> >  line 158
> > <http://reviewboard.kde.org/r/2534/diff/2/?file=16745#file16745line158>
> >
> >     See docs about this function: 
> > https://developer.skype.com/Docs/ApiDoc/SET_PROFILE_RICH_MOOD_TEXT
> >     
> >     It support smiles, but it has other syntax like kopete, so skype doesnt 
> > display smiles correct.

I used the function just because superseeds the MOOD_TEXT one. I hope to 
address the smiles and grunts later. 


- Alin M


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2534/#review3626
-----------------------------------------------------------


On 2010-01-09 12:39:59, Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2534/
> -----------------------------------------------------------
> 
> (Updated 2010-01-09 12:39:59)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> enhances skype wrapper and permits kopete to set the profile mood (status 
> message) for skype
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=221535.
>     
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=221535
> 
> 
> Diffs
> -----
> 
>   
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.h
>  1070407 
>   
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp
>  1070407 
>   
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp
>  1070407 
> 
> Diff: http://reviewboard.kde.org/r/2534/diff
> 
> 
> Testing
> -------
> 
> I have tested on linux, opensuse 11.2 with kde 4.3.87
> tested different manually set profiles Online, Away, Busy...
> and the now listen plugin too. 
> All seem to work...
> 
> 
> Thanks,
> 
> Alin M
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to