----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4151/#review5869 -----------------------------------------------------------
Some comments after a first glance: * The MPD support seems to have nothing to do with the MPRIS changes. If so, this should go in a separate patch. * Some new files are being added with old copyrights. * I thought the MPRIS stuff was supposed to completely replace the other plugins? - Raphael On 2010-05-25 21:41:57, Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4151/ > ----------------------------------------------------------- > > (Updated 2010-05-25 21:41:57) > > > Review request for Kopete. > > > Summary > ------- > > MPRIS is a dbus spec for mediaplayers. Supported players are for example > audacious, qmmp, xmms2, amarok, bmp, vlc, exaile, dragon player,.. > This new plugin uses the first MPRIS-player it finds. > > MPD (Music player daemon) support is not tested and adds a new optional > requirement for libmpdclient. Also for now it always connects to localhost. > That should be configurable later. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/CMakeLists.txt 1130643 > trunk/KDE/kdenetwork/kopete/cmake/modules/FindLibMPDClient.cmake > PRE-CREATION > trunk/KDE/kdenetwork/kopete/config-kopete.h.cmake 1130643 > trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt 1130643 > trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpd.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpd.cpp PRE-CREATION > trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris.cpp PRE-CREATION > trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp > 1130643 > > trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp > 1130643 > > Diff: http://reviewboard.kde.org/r/4151/diff > > > Testing > ------- > > Tested mpris support with audacious. > > MPD not tested. Perhaps someone who uses mpd could test please? MPD seems > difficult to setup. > > > Thanks, > > Cyberbeat > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
