> On 2010-05-27 03:41:59, Matt Rogers wrote: > > The code looks fine. Please commit. > > > > I'm a bit confused on how this works though. You're using an http proxy, > > but you've just set it up to listen on the normal SOCKS proxy port, and it > > still works? What happens if the proxy in use doesn't support that?
> set it up to listen on the normal SOCKS proxy port, and it still works? i use squid (from vanila debian package, I don't know whether it is http proxy or socks one). I added 'acl SSL_ports port 5190' to squid.conf and it worked. There were a lines # Deny CONNECT to other than SSL ports http_access deny CONNECT !SSL_ports >What happens if the proxy in use doesn't support that? 'Unknown error' is displayed in the plasma notification area. Such icq-via-proxy setup is used in the hostel of my university: there is a 10.x.x.x net w/o direct link to the internet, but for icq students can use icq.kpi.ua gate. Kopete not working via proxy was the main reason everybody was choosing gaim/gnome over kopete/kde. - Nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4163/#review5879 ----------------------------------------------------------- On 2010-05-27 03:29:09, Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4163/ > ----------------------------------------------------------- > > (Updated 2010-05-27 03:29:09) > > > Review request for Kopete. > > > Summary > ------- > > Makes Kopete respect global KIO proxy settings when connecting to ICQ. > > It uses 'https proxy' field of Systemsettings -> Network -> Proxy dialog. > > > This addresses bug 186872. > https://bugs.kde.org/show_bug.cgi?id=186872 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp 1130658 > > Diff: http://reviewboard.kde.org/r/4163/diff > > > Testing > ------- > > Kopete connected to my ICQ account via my home configured proxy (had to allow > 5190 port for CONNECT command in squid.conf), and refused to connect if I > specified wrong proxy settings. > > Kopete also connects to ICQ when I disable use of proxy. > > > Thanks, > > Nick > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel