> On 2010-06-10 16:40:34, Raphael Kubo da Costa wrote: > > The patch looks quite cluttered because of the automatic changes to the XML > > done by Designer: can you post a new version containing only your changes > > to the XML file? > > > > Other than that, as I usually say, I don't know the code -- if it works, we > > can ship it after trunk is open for feature commits again (ie it will make > > it for SC 4.6). > > > > Do you know if there's any bug report requesting this feature?
I was unsure how to handle the designer generated UI file. I thought messing with it manually would have a high chance of breaking it. So I just left it untouched. But I agree it hard to find out what is really needed for the feature. I'll try to create a more minimal patch for the ui file. > On 2010-06-10 16:40:34, Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp, > > line 71 > > <http://reviewboard.kde.org/r/4274/diff/1/?file=28321#file28321line71> > > > > Very minor nitpick: ( toggled() ) Not sure what you mean here. I tried to adapt to the coding style in that file. The above line was more a less a copy of the line 5 lines above in that file. But probably I missunderstood your comment. > On 2010-06-10 16:40:34, Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp, > > line 401 > > <http://reviewboard.kde.org/r/4274/diff/1/?file=28321#file28321line401> > > > > Very minor nitpick: extra empty line. I'll remove that in the next iteration, when I fixed the ui file. - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4274/#review6080 ----------------------------------------------------------- On 2010-06-10 14:05:46, Ralf Haferkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4274/ > ----------------------------------------------------------- > > (Updated 2010-06-10 14:05:46) > > > Review request for Kopete and Olivier Goffart. > > > Summary > ------- > > This patch adds the ability to adjust the priority of a jabber resource when > going to an "away" state. This can be used to "redirect" messages to a > different resource (e.g an IM client on a mobile device) base on the presence > state of kopete. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1136354 > > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui > 1136354 > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.h > 1136354 > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp > 1136354 > > Diff: http://reviewboard.kde.org/r/4274/diff > > > Testing > ------- > > Tested with current trunk: > > 1. Configure a priority for the away state in the account settings, lower > than the "normal" priority. > 2. Go online with kopete and another IM client (which has configured a > priority less the kopetes "normal priority" bug higher than the "away > priority" > 3. Set the state to "away" in kopete. > 4. Sent an IM to the account. Watch it arrive on the other client. > > > Thanks, > > Ralf > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
