----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4357/#review6356 -----------------------------------------------------------
Hi Igor. I'm trying to apply your patch here but it fails to compile. /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp: In constructor ‘TranslatorPreferences::TranslatorPreferences(QWidget*, const QStringList&)’: /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp:36:155: warning: ‘KCModule::KCModule(const KComponentData&, QWidget*, const QStringList&)’ is deprecated (declared at /home/rakuco/kde4/include/kcmodule.h:125) /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp:48:30: error: no matching function for call to ‘TranslatorLanguages::languagesMap()’ /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorlanguages.h:49:31: note: candidate is: const QMap<QString, QString>& TranslatorLanguages::languagesMap(const QString&) /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp:50:23: error: ‘class Ui::TranslatorPrefsUI’ has no member named ‘myLang’ /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp:50:74: error: no matching function for call to ‘TranslatorLanguages::languageIndex(const QString&)’ /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorlanguages.h:43:6: note: candidate is: int TranslatorLanguages::languageIndex(const QString&, const QString&) const /home/rakuco/kde4/src/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp:54:23: error: ‘class Ui::TranslatorPrefsUI’ has no member named ‘Service’ Can you please fix the issues and post a new patch against trunk (I've already separately committed the whitespace fixes and the translatorprefs -> translatorpreferences parts)? - Raphael On 2010-06-25 22:23:52, Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4357/ > ----------------------------------------------------------- > > (Updated 2010-06-25 22:23:52) > > > Review request for Kopete. > > > Summary > ------- > > This patch makes translator plugin for kopete work again; it adds support for > different language lists for different services; it adds up-to-date info > about languages and supported translations (for google and for babelfish); it > also ports KCM of this plugin to KConfigXT. > > What must be default behaviour when we cannot translate message? I think we > mustn't send it anyway (it was the default behaviour) > > > This addresses bugs 164870, 167503, 168026, 213133, 230686, and 234225. > https://bugs.kde.org/show_bug.cgi?id=164870 > https://bugs.kde.org/show_bug.cgi?id=167503 > https://bugs.kde.org/show_bug.cgi?id=168026 > https://bugs.kde.org/show_bug.cgi?id=213133 > https://bugs.kde.org/show_bug.cgi?id=230686 > https://bugs.kde.org/show_bug.cgi?id=234225 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/translator/CMakeLists.txt 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorconfig.kcfg > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorconfig.kcfgc > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatordialog.cpp > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorlanguages.h > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorlanguages.cpp > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorplugin.h 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorplugin.cpp > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorpreferences.h > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorprefs.cpp 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorprefsbase.ui > 1142865 > > Diff: http://reviewboard.kde.org/r/4357/diff > > > Testing > ------- > > Tested translations en_ru, ru_en, en_es and some others for both babelfish > and google services; tested changing services (menu entry must update then); > tested incoming and outgoing message translations (with different options) > > > Thanks, > > Igor > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
