> On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > Most changes needed are cosmetic or related to variable names/coding style. > > > > I don't use the Yahoo protocol, so I can't test your changes, so I'm > > assuming they work fine. As for bug 194833, you could try to ask for more > > information on the bug report to see if these changes fix it. > > > > From a code management point of view, I'd rather see these changes in > > different patches (the ones to the receiving end don't seem to be related > > to the sending end), but ReviewBoard isn't very helpful for this :/
a) re: that bug.. I think I'll wait for the fixes to be incorporated and then ask the guy to see if it works for him. Besides some dump from kdebug, after activating at leasy yahoo raw debug, not sure for now what to ask. b) I think it crossed my mind to have them in separate patches. don't know what happened :-) - Cristi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6339/#review9677 ----------------------------------------------------------- On Jan. 16, 2011, 10:33 a.m., Cristi P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6339/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 10:33 a.m.) > > > Review request for Kopete. > > > Summary > ------- > > Receive part: > a) protocol (as reading from various places) suggests that first a HEAD and > then GET should be done. Current code was asking them in parallel. > b) fixed the way sending the header was done. > > Sending: > a) changed to an async method of doing the send > b) send buffer size is dynamic to try to send as much as possible > c) ... various - made it work. > > Maybe fixes also #194833 although I'm not very sure what is that one about. > > > This addresses bugs and 242557. > https://bugs.kde.org/show_bug.cgi?id= > https://bugs.kde.org/show_bug.cgi?id=242557 > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp > 1214563 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.h > 1214563 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.h > 1214563 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp > 1214563 > > Diff: http://svn.reviewboard.kde.org/r/6339/diff > > > Testing > ------- > > sending from kopete to pidgin and Yahoo messenger, and the other way around. > Sending was always failing for me. > (and posted a patch to pidgin/libpurple as well :-) ) > > > Thanks, > > Cristi > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
