-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6421/
-----------------------------------------------------------
Review request for Kopete.
Summary
-------
see linked bug report. Basically, sometimes, kopete is displaying in duplicate
incoming messages.
Checking my log, I saw the following:
a) yahoo wasn't actually sending the message in duplicate.
b) but YahooACcount::slotGotIm() was called twice on that message
c) somewhere before the problematic thing - and I actually saw many things
being done in duplicate (not just messages), I saw this:
kopete(8352)/kopete (yahoo - raw protocol) Client::slotLoginResponse: Emitting
loggedIn
kopete(8352)/kopete (yahoo) YahooAccount::slotLoginResponse: -1 , "" )]
d) checking code in yahooaccount.cpp - it seems that for that code (and
others), it considers that account is offline, but forgets to also disconnect
all the signals. So, next time user logins (even by an auto-reconnect), the
signals are connected *again* to the same sources. And that's why it gets to do
things 2 times.
This addresses bug 206159.
https://bugs.kde.org/show_bug.cgi?id=206159
Diffs
-----
trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahooaccount.cpp 1217129
Diff: http://svn.reviewboard.kde.org/r/6421/diff
Testing
-------
changed client.cpp to behave like something went wrong w/ the login and emit
code -1 in slotLoginResponse, at 2nd or 3rd login try.
Then I login, then logout a couple of times. When it considers it failed the
login, I am waiting for it to login back, this time successfully. then I sent a
message from a different account, and... it started to show them twice.
Thanks,
Cristi
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
