> On Nov. 17, 2009, 3:01 a.m., Matt Rogers wrote: > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp, > > lines 134-135 > > <http://svn.reviewboard.kde.org/r/2159/diff/1/?file=14426#file14426line134> > > > > do this check first and you can skip all the casting if it's not a > > metacontact
Patch applied to trunk. Please close this review request. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/2159/#review3132 ----------------------------------------------------------- On Nov. 17, 2009, 3:35 a.m., Barry Carter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/2159/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2009, 3:35 a.m.) > > > Review request for Kopete. > > > Summary > ------- > > This patch allows the contact quicksearch to search: MetaContact name, email > address and also MetaContact-> account contact names. > The patch works by expanding the search parameters when filterRegExp is not > empty. > An additional feature of the patch is that it will remove group folders if > there is no search result. This feature could be considered weak in that it > walks the list of metacontacts for each group. If the search filterRegExp is > found within the group's contacts, then the group folder is allowed to be > shown. As you can imagine, for lots of contacts per folder, evaluating the > regexp twice per metacontact could be slow (still seemed usable with 10000 > contacts) > > I would add that this is a first time kopete code fix for me, and I probably > implemented some of the casting etc. the hard way. Pointers are welcome! > > > Diffs > ----- > > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.h > 1046954 > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp > 1046954 > > Diff: http://svn.reviewboard.kde.org/r/2159/diff > > > Testing > ------- > > > Thanks, > > Barry > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
