Em Saturday 25 February 2012, Pali Rohár escreveu:
> Hi,
> 
> I'm attaching updated patch. Old patch on reviewboard cannot apply on
> kopete from trunk. I tried to update patch also on reviewboard, but I do
> not have permission to update it (I'm not author of that review/patch).

        Well, I think instead of connecting to resumingFromSuspend signal in 
line

QDBusConnection::sessionBus().connect( "org.kde.Solid.PowerManagement", 
"/org/kde/Solid/PowerManagement", "org.kde.Solid.PowerManagement", 
"resumingFromSuspend", this, SLOT( resume() ) );

you should connect to statusChanged signal from Solid::Networking. It takes 
several seconds to establish Internet connection after the resume, specially 
for wifi, which is a common case. Checking for Solid::Networking::status() 
right after resume will mostly return Solid::Networking::Unknown or 
Disconnected depending on if the network manager software had started or not 
before Kopete receives the resumingFromSuspend signal.

PS: when creating a patch with diff command use --show-c-function option to 
show which class method the lines in the patch belongs to.
 
> On Saturday 20 August 2011 09:31:55 Pali Rohár wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://svn.reviewboard.kde.org/r/6511/#review10359
> > -----------------------------------------------------------
> > 
> > 
> > I cannot apply this patch on kopete from trunk. Can you update it?
> > 
> > - Pali
> > 
> > On March 1, 2011, 9:39 p.m., alter_schwede wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://svn.reviewboard.kde.org/r/6511/
> > > -----------------------------------------------------------
> > > 
> > > (Updated March 1, 2011, 9:39 p.m.)
> > > 
> > > 
> > > Review request for Kopete.
> > > 
> > > 
> > > Summary
> > > -------
> > > 
> > > I already posted this patch here:
> > > https://bugs.kde.org/show_bug.cgi?id=149544
> > > 
> > > This patch logs off each account when PC is suspended and restores the
> > > online state of each account on resume. This patch also addresses
> > > another problem of kopete: When the user was setting kopete to
> > > "Offline" and the network connection was lost and recovered kopete
> > > would reset all accounts to "Online".
> > > 
> > > 
> > > This addresses bugs 149544 and 212037.
> > > 
> > >     https://bugs.kde.org/show_bug.cgi?id=149544
> > >     https://bugs.kde.org/show_bug.cgi?id=212037
> > > 
> > > Diffs
> > > -----
> > > 
> > >   /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h
> > >   1222426
> > >   /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp
> > >   1222426
> > >   /branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml 1222426
> > >   /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h 1222426
> > >   /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp
> > >   1222426
> > >   /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h
> > >   1222426
> > >   /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cp
> > >   p 1222426>
> > > 
> > > Diff: http://svn.reviewboard.kde.org/r/6511/diff
> > > 
> > > 
> > > Testing
> > > -------
> > > 
> > > 
> > > Thanks,
> > > 
> > > alter_schwede


-- 
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to