> On jún 20, 2015, 6:16 popoludní, Laurent Montel wrote: > > plugins/texteffect/texteffectpreferences.cpp, line 149 > > <https://git.reviewboard.kde.org/r/124094/diff/4/?file=380500#file380500line149> > > > > better to use ++f > > Roman Nazarenko wrote: > No it's not. It doesn't matter whether post- or pre-increment operator is > used for integral types in such case. Just a matter of preference.
Yes, in case of internal types when return value of post-increment operator is not used, modern compilers generate same (optimized) code. - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review81595 ----------------------------------------------------------- On jún 21, 2015, 1:41 popoludní, R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124094/ > ----------------------------------------------------------- > > (Updated jún 21, 2015, 1:41 popoludní) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Replace the K3ListBox classes with QListWidget. > > > Diffs > ----- > > plugins/texteffect/texteffectpreferences.cpp > 35fac60d419cbac5644a8e143be1fc7c640385a9 > plugins/texteffect/texteffectprefs.ui > 1b82f3de4b449373a3dedb39b664c0f645f1d02a > > Diff: https://git.reviewboard.kde.org/r/124094/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
