> On July 21, 2015, 12:46 a.m., Laurent Montel wrote: > > plugins/autoreplace/autoreplacepreferences.cpp, line 120 > > <https://git.reviewboard.kde.org/r/124227/diff/3/?file=386407#file386407line120> > > > > What do you think about > > for (int i = 0; i < prefer...->m_list->toplevelitemcount() ; ++i) { > > QTreeWidgetItem *item = ...->m_list->toplevelitem(i); > > newWords[item->text(0)] = ...; > > > > } > > ?
Yes, it's much less complicated this way. The script that I used replaced the Q3ListViewItem occurence with QTreeWidgetItem and I never thought of anything else thereafter. - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/#review82722 ----------------------------------------------------------- On July 20, 2015, 10:48 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124227/ > ----------------------------------------------------------- > > (Updated July 20, 2015, 10:48 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Replace the Q3ListView classes with QTreeWidgets. > > > Diffs > ----- > > plugins/autoreplace/autoreplacepreferences.cpp > dab6645f0552e6066ae8da09a35654d7dbaca8db > plugins/autoreplace/autoreplaceprefs.ui > 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 > > Diff: https://git.reviewboard.kde.org/r/124227/diff/ > > > Testing > ------- > > Build Succeeds. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
