----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 -----------------------------------------------------------
libkopete/ui/addressbookselectorwidget.cpp (line 141) <https://git.reviewboard.kde.org/r/124344/#comment57080> Where are used links for this label? Because I did not find any. libkopete/ui/addressbookselectorwidget.cpp (line 142) <https://git.reviewboard.kde.org/r/124344/#comment57081> TextEditorInteraction = TextSelectableByMouse | TextSelectableByKeyboard | TextEditable Why it is needed? Have you looked what this lblHeader means and where is used? libkopete/ui/metacontactselectorwidget.cpp (line 21) <https://git.reviewboard.kde.org/r/124344/#comment57082> Is this change needed? And if yes it is cosmetic, should be in separate commit and should change all includes qclass.h to QClass. Not just only one. Then we will have big mess. libkopete/ui/metacontactselectorwidget.cpp (line 297) <https://git.reviewboard.kde.org/r/124344/#comment57083> same here - Pali Rohár On júl 20, 2015, 4:01 popoludní, R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124344/ > ----------------------------------------------------------- > > (Updated júl 20, 2015, 4:01 popoludní) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Use QLabel instead of K3ActiveLabel > > > Diffs > ----- > > libkopete/ui/addressbookselectorwidget.cpp > d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 > libkopete/ui/addressbookselectorwidget_base.ui > de6ec4d24cd10eebfebc11b4fb9839be206552dc > libkopete/ui/metacontactselectorwidget.cpp > 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a > libkopete/ui/metacontactselectorwidget_base.ui > 1f69a48c559ab3f002700068ec6a6c200a9242e3 > > Diff: https://git.reviewboard.kde.org/r/124344/diff/ > > > Testing > ------- > > Build succeeded. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
