> On July 26, 2015, 11:19 a.m., Laurent Montel wrote: > > kopete/contactlist/kopeteaddrbookexport.cpp, line 109 > > <https://git.reviewboard.kde.org/r/124305/diff/3/?file=387733#file387733line109> > > > > Why you don't : > > QListWidgetItem *item = new QListWidgetITem(QIcon, QString); > > QListWidget::addITem(item); ?
Aah, you're right. Much neater. I'll update the patch. - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82968 ----------------------------------------------------------- On July 26, 2015, 11:13 a.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124305/ > ----------------------------------------------------------- > > (Updated July 26, 2015, 11:13 a.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Removes all occurences of the K3ListBox classes in the kopete main > application. > > > Diffs > ----- > > kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 > kopete/contactlist/kopeteaddrbookexport.h > 4774ba8efe89cea5282a9566ec685a913012cece > kopete/contactlist/kopeteaddrbookexport.cpp > 8f285bf23dcad7336bd05b2697a300e983ceca73 > kopete/contactlist/kopeteaddrbookexportui.ui > ec6ec9bc5c693b6df06499062defd1865a0a9c4f > kopete/contactlist/kopetestatusgroupviewitem.h > fb4a20648e1b12d464e98c51b8638f7d618ef53f > kopete/contactlist/kopetestatusgroupviewitem.cpp > 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 > > Diff: https://git.reviewboard.kde.org/r/124305/diff/ > > > Testing > ------- > > Build succeeded. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
