Stewart Stremler wrote:
The first thing I tend to do is to rewrite the code, but that
just offends the maintainers ("My code is self documenting. Why
did you go through and add vowels to all my variables?") -- and
I'm too lazy to fork a project for pretty code.
Unless you wrote tests, I know that *I* would reject your code.
Rewrites without tests introduce bugs.
We'd discussed this awhile back, IIRC, in IRC. Stuff like starting a
peer-review process -- don't look at what the code does, look at how
readable, comprehensible, and maintainable code is. Encourage the
community to create code that _isn't_ painful to read.
How about we start with code that actually functions? I will take code
with tests any day over "readable" code.
I can rewrite code with tests if I really need to. If I am going to
rewrite code without tests, I have to stop and write the tests first.
And making someone else's code beautiful isn't rewarding work. Thus,
it's not often done.
As well it shouldn't. Making code "pretty" is a case of premature
optimization.
"Pretty" == mantainable, IMNSHO.
The only way to determine which sections are not "maintainable" is to
put it into production and see where the bugs pop up. Areas of code
which have the most likely need to be rewritten.
-a
--
[email protected]
http://www.kernel-panic.org/cgi-bin/mailman/listinfo/kplug-list
