begin quoting Andrew Lentvorski as of Sun, Jun 04, 2006 at 01:14:55PM -0700:
[snip]
> The other problem is that people who are "rearranging whitespace" in C
> quite often get it *wrong*.
>
> They try and rearrange
>
> if (foo) {
> something;
> }
>
> to
>
> if (foo)
> something;
>
> and forget something.
<shudder>
I hate it when people _remove_ braces.
But whenever someone touches the code, there's a chance for error,
even if they're not reformatting. ("I add logging statements, and
it no longer crashes, but I get the wrong answer!")
I tend to go the other way -- I add braces, not remove them.
Granted, this is still dangerous. Looking at
if(foo)
something;something else;
one may write
if ( foo ) {
something; something else;
}
and thus introduce a change.
But then, this sort of basic reformatting can largely be done with tools.
--
_ |\_
\|
--
[email protected]
http://www.kernel-panic.org/cgi-bin/mailman/listinfo/kplug-list