On Wed, 19 Dec 2007 10:44:34 -0800, David Brown <[EMAIL PROTECTED]> wrote:

On Wed, Dec 19, 2007 at 10:37:37AM -0800, MattyJ wrote:

Also, Perforce's 'diff2' app with a '-u' switch should provide you with output that can be properly digested by 'patch'.

But it only works if the change has been checked in. It isn't very useful
to send a work patch off to someone for feedback before you check it in.

Dave



Philosophically, that seems fine to me. I'd rather check my own crummy ideas in separately from my reviewers so it's clear in the history that a review took place, and changes occurred because of them. I check my work in frequently, all day long. I'd rather not hold a file open for a few days until someone else looks at it. But I'm overly paranoid about that kinda thing.


-Matt


--
[email protected]
http://www.kernel-panic.org/cgi-bin/mailman/listinfo/kplug-list

Reply via email to