On Fri, December 22, 2006 8:21 am, George Geller wrote:
> This perl script works, but is not a idomatic perl.
> How would a perl expert write it?
> This is my second perl script that will actually be used by somebody else.
>
>
-snip of a working perl script with comments and everything.

I'd recommend leaving it alone.

- the perl ethos says if it works, it's good perl

- idiomatic perl is like early C: full of little nested tricks that
shorten code at the expense of readability. In C before optimizers, it at
least made smaller object code. I've never heard that excuse for perl.

- procedural perl is easier to read, maintain, tinker with and debug.

- modifying any working code just to make it perty runs the risk of
introducing errors.

My recommendation is to deliver what you showed us (very professional) and
go on to other things.

-- 
Lan Barnes

SCM Analyst              Linux Guy
Tcl/Tk Enthusiast        Biodiesel Brewer

-- 
[email protected]
http://www.kernel-panic.org/cgi-bin/mailman/listinfo/kplug-lpsg

Reply via email to