David Brown wrote:
On Sat, Nov 01, 2008 at 11:34:53PM -0700, Darren New wrote:
What about "this code needs more comments"? :-)
That's why ever change must also be reviewed before it can be
submitted. At least that can help with that.
I'm not sure how that would help in this situation. Are you saying
"disallow submitting this request for more comments" or are you saying
"never get into a situation where you need more comments on already
checked-in code"? I don't think it's reasonable to deny either one.
Basically, the problem is you can't check in a refactoring. You would
have to refactor *and* change functionality in the same check-in,
because the point of a refactor is it doesn't break any tests. :-)
--
Darren New / San Diego, CA, USA (PST)
--
KPLUG-LPSG@kernel-panic.org
http://www.kernel-panic.org/cgi-bin/mailman/listinfo/kplug-lpsg
