Hi Valentin, Am 14.10.2010 14:10, schrieb Valentin Rusu: > For ACL handling a new CreateCollectionJob calling path parameter is needed > - the PeerInfo. This class is initialized by the Service::CreateCollection > d-bus exposed method with d-bus contextual information. This structure needs > to be given to all CreateCollectionJobs along with the existing parameters > (label and locked). So it will finally reach the ACL handling job I intend > to create. > > This kind of code refactoring involves lots of files, though the behaviour > is typically not affected. In order to simplify future refactoring on the > CreateCollectionJobs, I prefered to create a helper structure named > CreateCollectionInfo, wich will have three members as of now : the label, > the locked flag and the PerrInfo pointer. In the event some other > information may be needed to be given along CreateCollectionJobs path, it > would take only a member addition into this structure. >
Sounds good and will probably make the internal API more stable. Quite a commit :-) Now I know what I'll do this weekend :-) Regards, Michael _______________________________________________ Ksecretservice-devel mailing list Ksecretservice-devel@kde.org https://mail.kde.org/mailman/listinfo/ksecretservice-devel
