Hi Valintin, I certainly agree that KDE and GNOME should be using the same object paths and interface names. Sorry about that mix up.
The most recent version of the specification is at: http://people.collabora.co.uk/~stefw/secret-service/ I need to do my job as a spec editor better. I'm requesting space on freedesktop.org to host the official version, and like you suggested we need to update the version number. I can understand the desire to have everything consistently say 'secrets' rather a mixture of 'secrets' and 'Secret'. When designing it we thought that interface names would say 'Secret.Service' 'Secret.Collection' and 'Secret.Item', as that rolls off the tongue and matches with the name of the API. But then that object paths would say 'secrets' as they contain more than one secret. I agree that this is somewhat questionable logic. However at this stage, do we really need to make the object paths and interface names consistent with one another? It would break all sorts of implementations. The last set of (necessary) changes got a lot of complaints. I would really rather not break things again just for cosmetic reasons. What do you think? Cheers, Stef On 04/25/11 21:14, Valentin Rusu wrote: > Hello Stef, > > Trying to sort out the problem rose by Alin (see original message > below), I took a look into the gnome-keyring sources and into the spec. > > This spec chapter : > http://people.collabora.co.uk/~stefw/secret-service/ch12.html > <http://people.collabora.co.uk/%7Estefw/secret-service/ch12.html> > introduces /org/freedesktop/secrets as a base name for objet paths. > > However, base names for the various interfaces is org.freedesktop.Secret > as per > http://people.collabora.co.uk/~stefw/secret-service/ch13.html > <http://people.collabora.co.uk/%7Estefw/secret-service/ch13.html> > > Proposal n° 1 : let's stick with the first form of the names update the > spec as per patch n°1 : > - change the names of the interfaces, > - adjust object paths to match /org/freedesktop/secrets. > See patch named > "0002-Naming-scheme-is-now-more-consistant-between-object-.patch". > > Next, I took a look into gnome-keyring code and I'd like to submit > another patch named > "0001-Make-naming-scheme-more-consistent-between-paths-and.patch". > > If you agree with these, I'll go ahead and apply the same changes to KDE > playground code. > > Cheers, > Valentin > > > -------- Original Message -------- > Subject: [Ksecretservice-devel] secretservice clarificaions > Date: Mon, 25 Apr 2011 16:24:35 +0100 > From: Alin Marin Elena <alinm.el...@gmail.com> > Reply-To: alinm.el...@gmail.com, People working on ksecretservice > <ksecretservice-devel@kde.org> > Organization: School Of Physics, University College Dublin > To: le...@confuego.org, d...@kde.org, ksecretservice-devel@kde.org > > > > Hi all, > > I try to determine what is the agreed service name for secret service api > as this document does not spell it > http://code.confuego.org/secrets-xdg-specs/ > and libgnome seems to use org.freedesktop.secrets and ksecretservice > org.freedesktop.Secret... so I am sure at least one is in wrong... > > > other issue that Dario pointed out > http://code.confuego.org/secrets-xdg-specs/ch11.html > is that interface is Secret and the path is secrets. > > any comments would be useful, > > regards, > Alin > > -- > I force myself to contradict myself in order to avoid conforming to my own > taste. -- Marcel Duchamp > Without Questions there are no Answers! > _____________________________________________________________________ > Alin Marin ELENA > Advanced Molecular Simulation Research Laboratory > School of Physics, University College Dublin > ---- > Ardionsamblú Móilíneach Saotharlann Taighde > Scoil na Fisice, An Coláiste Ollscoile, Baile Átha Cliath > > ----------------------------------------------------------------------------------- > http://alin.elenaworld.net > ______________________________________________________________________ > _______________________________________________ > Ksecretservice-devel mailing list > Ksecretservice-devel@kde.org > https://mail.kde.org/mailman/listinfo/ksecretservice-devel > _______________________________________________ Ksecretservice-devel mailing list Ksecretservice-devel@kde.org https://mail.kde.org/mailman/listinfo/ksecretservice-devel
