Hi Valentin,

I have attached a proper patch now...

in the daemon folder you have some kde4_add_library with static attribute is 
that ok?

regards,
Alin


On Mon 08 Aug 2011 13:54:52 you wrote:
> On 08/08/2011 11:50 AM, Alin Marin Elena wrote:
> > Hi Valentin,
> > 
> > The libraries seem to be unversioned. I just added two quick patches to
> > solve the problem. The version and soversion probably will be best to be
> > set in the top level CMakelists...
> 
> Hey Alin,
> 
> Thanks for the patch - I just pushed it.
> 
> Cheers,
> Valentin
-- 
 Without Questions there are no Answers!
 _____________________________________________________________________
  Alin Marin ELENA
  Advanced Molecular Simulation Research Laboratory
  School of Physics, University College Dublin
  ----
  Ardionsamblú Móilíneach Saotharlann Taighde
  Scoil na Fisice, An Coláiste Ollscoile, Baile Átha Cliath

  
-----------------------------------------------------------------------------------
  http://alin.elenaworld.net
  ______________________________________________________________________
diff --git CMakeLists.txt CMakeLists.txt
index 3f9c4d7..13d32e7 100644
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -2,6 +2,15 @@ cmake_minimum_required(VERSION 2.6.4)
 
 PROJECT (ksecretservice)
 
+ # version
+SET(KSS_MAJOR_VERSION "0")
+SET(KSS_MINOR_VERSION "1")
+SET(KSS_PATCH_VERSION "0")
+
+SET(KSS_VERSION ${KSS_MAJOR_VERSION}.${KSS_MINOR_VERSION}.${KSS_PATCH_VERSION})
+
+
+
 FIND_PACKAGE (KDE4 REQUIRED)
 FIND_PACKAGE (QCA2 REQUIRED)
 
diff --git daemon/backend/CMakeLists.txt daemon/backend/CMakeLists.txt
index fb42fbc..215aa23 100644
--- daemon/backend/CMakeLists.txt
+++ daemon/backend/CMakeLists.txt
@@ -24,4 +24,6 @@ SET (ksecretservice_backend_SRCS
 )
 
 KDE4_ADD_LIBRARY (ksecretservicebackend STATIC ${ksecretservice_backend_SRCS})
+SET_TARGET_PROPERTIES ( ksecretservicebackend PROPERTIES VERSION ${KSS_VERSION} SOVERSION ${KSS_MAJOR_VERSION} )
+
 TARGET_LINK_LIBRARIES (ksecretservicebackend ${KDE4_KDECORE_LIBS} ${QCA2_LIBRARIES})
diff --git daemon/frontend/CMakeLists.txt daemon/frontend/CMakeLists.txt
index 8f5fc67..5725bfe 100644
--- daemon/frontend/CMakeLists.txt
+++ daemon/frontend/CMakeLists.txt
@@ -24,6 +24,9 @@ SET (ksecretservice_frontend_SRCS
 )
 
 KDE4_ADD_LIBRARY (ksecretservicefrontend STATIC ${ksecretservice_frontend_SRCS})
+SET_TARGET_PROPERTIES ( ksecretservicefrontend PROPERTIES VERSION ${KSS_VERSION} SOVERSION ${KSS_MAJOR_VERSION} )
+
+
 TARGET_LINK_LIBRARIES (ksecretservicefrontend 
     ksecretsservicelib
     ${KDE4_KDECORE_LIBS} 
diff --git daemon/kwlimporter/CMakeLists.txt daemon/kwlimporter/CMakeLists.txt
index 3579749..0caafeb 100644
--- daemon/kwlimporter/CMakeLists.txt
+++ daemon/kwlimporter/CMakeLists.txt
@@ -32,7 +32,9 @@ kss_add_dbus_interface(kwl_importer_SRCS ../../client/org.freedesktop.Secret.Pro
 kss_add_dbus_interface(kwl_importer_SRCS ../../client/org.freedesktop.Secret.Service.xml service_interface )
 kss_add_dbus_interface(kwl_importer_SRCS ../../client/org.freedesktop.Secret.Session.xml session_interface )
 
-kde4_add_library(kwl_importer ${kwl_importer_SRCS})
+kde4_add_library(kwl_importer STATIC ${kwl_importer_SRCS})
+SET_TARGET_PROPERTIES ( kwl_importer PROPERTIES VERSION ${KSS_VERSION} SOVERSION ${KSS_MAJOR_VERSION} )
+
 target_link_libraries(kwl_importer ${KDE4_KDECORE_LIBRARY} ${QT_QTDBUS_LIBRARY} 
     ksecretservicefrontend 
     ksecretservicebackend
diff --git daemon/lib/CMakeLists.txt daemon/lib/CMakeLists.txt
index 05539c9..51d0fe5 100644
--- daemon/lib/CMakeLists.txt
+++ daemon/lib/CMakeLists.txt
@@ -11,6 +11,7 @@ SET( daemonlib_SRCS
 )
 
 KDE4_ADD_LIBRARY( daemonlib STATIC ${daemonlib_SRCS} )
+SET_TARGET_PROPERTIES ( daemonlib PROPERTIES VERSION ${KSS_VERSION} SOVERSION ${KSS_MAJOR_VERSION} )
 
 target_link_libraries( daemonlib
     ${KDE4_KDECORE_LIBRARY}
diff --git daemon/ui/CMakeLists.txt daemon/ui/CMakeLists.txt
index d9828d8..f954db1 100644
--- daemon/ui/CMakeLists.txt
+++ daemon/ui/CMakeLists.txt
@@ -22,6 +22,7 @@ KDE4_ADD_UI_FILES( ksecretservice_ui_SRCS
 )
     
 KDE4_ADD_LIBRARY (ksecretserviceui STATIC ${ksecretservice_ui_SRCS})
+SET_TARGET_PROPERTIES ( ksecretserviceui PROPERTIES VERSION ${KSS_VERSION} SOVERSION ${KSS_MAJOR_VERSION} )
 
 TARGET_LINK_LIBRARIES (
     ksecretserviceui 
diff --git lib/CMakeLists.txt lib/CMakeLists.txt
index 29f1f47..c008cb2 100644
--- lib/CMakeLists.txt
+++ lib/CMakeLists.txt
@@ -12,7 +12,7 @@ SET (ksecretservice_lib_SRCS
 )
 
 KDE4_ADD_LIBRARY (ksecretsservicelib SHARED ${ksecretservice_lib_SRCS})
-SET_TARGET_PROPERTIES ( ksecretsservicelib PROPERTIES VERSION 1.0.0 SOVERSION 1 )
+SET_TARGET_PROPERTIES ( ksecretsservicelib PROPERTIES VERSION ${KSS_VERSION} SOVERSION ${KSS_MAJOR_VERSION} )
 
 TARGET_LINK_LIBRARIES (ksecretsservicelib 
     ${QT_QTCORE_LIBRARY} 

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Ksecretservice-devel mailing list
Ksecretservice-devel@kde.org
https://mail.kde.org/mailman/listinfo/ksecretservice-devel

Reply via email to