----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119969/#review102625 -----------------------------------------------------------
Seems this was commited at some point, closing. - Albert Astals Cid On Aug. 28, 2014, 10:38 a.m., Alexander Volkov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119969/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 10:38 a.m.) > > > Review request for KSecretService. > > > Repository: ksecrets > > > Description > ------- > > ksecrets_export.h is already generated and it's preferable to use it. > > > Diffs > ----- > > src/api/ksecrets/ksecretsservicecodec.h d5edb8a > src/api/ksecrets/ksecretsservicecollection.h bbc3140 > src/api/ksecrets/ksecretsservicecollectionjobs.h beb6082 > src/api/ksecrets/ksecretsserviceitem.h d35a96e > src/api/ksecrets/ksecretsserviceitemjobs.h e673485 > src/api/ksecrets/ksecretsservicemacros.h 877353a > src/api/ksecrets/ksecretsservicesecret.h d91a617 > > Diff: https://git.reviewboard.kde.org/r/119969/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Volkov > >