Hi! ----
Here comes round "one" of the pre-pre-preliminary code review for the first update of the ksh93 integration project: I created a webrevs based on today's (2007-11-10) ksh93-integration prototype010 Subversion tree. This isn't the "preliminary review request" (yet (or is it official (due lack of an ARC case))), just an attempt to get some feedback on the code. The webrev can be found at http://cr.opensolaris.org/~gisburn/ksh93_integration/ksh93_update1/webrev_20071110/ ** Notes/comments: * Most of the files cover a simple update but we have lots of new code, including: - usr/src/cmd/ksh/ now contains a subdirectory builtins/ which handles the mapping the commands "alias", "command", "fc", "fg", "getopts", "hash", "jobs", "kill", "printf", "read", "rev", "sleep", "sum", "test", "type", "ulimit", "umask", "unalias", "wait" (most of them were previously mapped to /usr/bin/ksh) - usr/src/cmd/shcomp/ contains the ksh93 shell script compiler - usr/src/cmd/nsadmin/ksh.kshrc contains a change which provides a default "PS1" based on a similar prompt delivered by SuSE. The change may be commented out in the final version to simplify the ARC case - usr/src/lib/libsum/ contains a new library from AT&T which handles cipher hashing method for the ksh93 "sum" builtin - usr/src/uts/ contains a new exec kernel module to recognize compiled shell scripts (generated by "shcomp" ; this module works in a similar way as the "javaexec" exec module) * The following utilties are affected by the change: - /usr/bin/kill's output for the "-l" option now uses newline as delimiter for values instead of a SPACE (both standard and the manual page explicitly allow both forms) - /usr/bin/printf is now mapped to ksh93's builtin command (e.g. another piece of closed-source software is gone and we get support for C99/XPG6, too... :-) ) - /usr/bin/sleep is now mapped to ksh93's "sleep" builtin (which finally provides sub-second timeouts and C99/XPG6 conformance) - /usr/bin/sum is now mapped to ksh93's "sum" builtin (which includes lots of new functionality, including selectable ciphers) - /usr/bin/test now supports additional options and sub-second timestamps for files (ksh88 only supported 1sec granularity) - /usr/bin/ulimit's output for the "-a" option has changed, however the output is considered "not an interface", e.g. only for informative purposes * Missing items: - We still have to finish the ARC case - The alternative codepath for |libc::wordexp()| still needs to be updated to use |posix_spawn()| Thanks in advance for your help! ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
