Roland Mainz writes:
> http://svn.genunix.org/repos/on/branches/ksh93/gisburn/prototype004/usr/src/cmd/ksh/Makefile.com
(Have there been any code reviews yet ... ?)
In that file, I see the following:
export \
SHELL="$(SRC)/cmd/ksh/$(CMDTRANSMACH)/ksh" \
LD_LIBRARY_PATH="$(ROOT)/usr/lib/$(MACH64):$(ROOT)/usr/lib/" ; \
sync ; sync ; \
Besides the errant 'sync' invocations -- which don't belong here under
any circumstances, as they'll burden the build server for no reason --
this use of LD_LIBRARY_PATH cannot stand.
There's no guarantee whatsoever that the libraries and binaries found
in the proto area (under $ROOT) can or will actually run on the build
machine. In fact, we can guarantee that they WILL NOT run correctly
when there are libc/kernel flag days.
This is why, in the very, very rare cases where we must produce
binaries to be executed on the build system, we use a separate set of
targets and symbols. See NATIVE_CFLAGS, NATIVE_MACH, NATIVECC, and
the related bits in $SRC/Makefile.master.
This is also one of the many reasons why tests are *not* performed as
part of the nightly build, but rather as part of a separate test
suite.
Please do not integrate with this $LD_LIBRARY_PATH hack.
--
James Carlson, KISS Network <james.d.carlson at sun.com>
Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
