"I. Szczesniak" wrote:
> On 5/13/09, Roland Mainz <roland.mainz at nrubsig.org> wrote:
[snip]
> > The webrev can be found at
> >
> > http://cr.opensolaris.org/~gisburn/ksh93_integration_update2_20090511_webrev/
> > , test binaries are available at
> >
> > http://www.opensolaris.org/os/project/ksh93-integration/downloads/2009-05-11/
> > and the HG export code chunk is available at
> >
> > http://www.opensolaris.org/os/project/ksh93-integration/downloads/ksh93_integration_update2_20090511_hg_export_001.hgexport.bz2
> > (MD5 hash is "6c8f765ba7593c4d87aedf9cefca396a").
> >
> > Notes:
> > - the following directories contain "upstream" sources which do not
> > require review (or require to be cstyled etc.):
>
> Below you find my review:
>
> usr/src/cmd/ksh/builtins/alias.c line 38:
> #include <stdbool.h> is not required.
Fixed.
> The new file usr/src/tools/findunref/exception_list.subversion does
> not have a corresponding bug id.
Fixed (I filed CR #6841442 ("Need exception list for OS/Net trees
managed via Subversion"))
> The change for usr/src/tools/scripts/Makefile does not have a
> corresponding bug id.
I backed this change out. Technically it's a bug in the logic but I am
going to fix that with a putback for a webrev fix.
> usr/src/cmd/ksh/builtins/Makefile lines 98, 99:
> Is -z lazyload missing or do the global ON flags now do that?
Erm... good question... technically OS/Net uses "-Bdirect", e.g. "direct
linking" which should behave like "lazyload" ... but on the other side I
see in debuggers like "dbx" that "-Bdirect" has no effect on it... I'll
split this part off and ask the linker folks...
> usr/src/lib/libshell/common/bltins/poll_solaris.c lines 142-147:
> Description for option -c does not match the function. The code
> returns an array and not a variable.
Fixed.
> usr/demo/ksh/tests should contain a short README which explains how to
> use the test suite.
Fixed.
> Please fix the spelling errors in shell_styleguide.docbook
Fixed.
> All other changes look good to me.
Thanks! :-)
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
